Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1836013003: Don't change toolbar padding when hiding buttons if home page button is showing (Closed)

Created:
4 years, 8 months ago by Theresa
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't change toolbar padding when hiding buttons if home page button is showing If the home page button is showing, the start padding for the toolbar shouldn't be adjusted because the home page button will already provide the appropriate padding. BUG=598409 Committed: https://crrev.com/918aa39cf33102e63a1e8c1a29e7bd65fb457b63 Cr-Commit-Position: refs/heads/master@{#383642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Theresa
ptal at this (very) tiny CL
4 years, 8 months ago (2016-03-28 23:41:15 UTC) #2
newt (away)
lgtm
4 years, 8 months ago (2016-03-29 01:07:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836013003/1
4 years, 8 months ago (2016-03-29 01:08:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 01:13:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 01:14:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918aa39cf33102e63a1e8c1a29e7bd65fb457b63
Cr-Commit-Position: refs/heads/master@{#383642}

Powered by Google App Engine
This is Rietveld 408576698