chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java - Issue 1836013003: Don't change toolbar padding when hiding buttons if home page button is showing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 1836013003: Don't change toolbar padding when hiding buttons if home page button is showing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

index c0bad448d6e6f4cdf6009049765d87601078b298..4c007baa1bf9de6151231a16245713f97e348f88 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

@@ -465,8 +465,10 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {

mLocationBar.setShouldShowButtonsWhenUnfocused(visible);

+ boolean buttonsVisible = mHomeButton.getVisibility() == View.VISIBLE

+ || visible;

ApiCompatibilityUtils.setPaddingRelative(this,

- visible ? mStartPaddingWithButtons : mStartPaddingWithoutButtons,

+ buttonsVisible ? mStartPaddingWithButtons : mStartPaddingWithoutButtons,

getPaddingTop(),

ApiCompatibilityUtils.getPaddingEnd(this),

getPaddingBottom());

« no previous file with comments | « no previous file | no next file » | no next file with comments »