Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 18360008: Remove support for [EventTarget] IDL extended attribute (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

Remove support for [EventTarget] IDL extended attribute Remove support for [EventTarget] IDL extended attribute now that all interfaces inherit EventTarget instead. Also remove EventTarget special casing from the bindings generator as these are no longer needed. BUG=257583 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154010

Patch Set 1 #

Patch Set 2 : Rebaseline bindings tests #

Total comments: 3

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -33 lines) Patch
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 8 chunks +5 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/EventTarget.idl View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm File Source/bindings/scripts/deprecated_code_generator_v8.pm (left): https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm#oldcode5492 Source/bindings/scripts/deprecated_code_generator_v8.pm:5492: if (IsDOMNodeType($type) || $type eq "EventTarget") { This if ...
7 years, 5 months ago (2013-07-11 11:45:31 UTC) #1
haraken
LGTM. Great. https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm File Source/bindings/scripts/deprecated_code_generator_v8.pm (left): https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm#oldcode172 Source/bindings/scripts/deprecated_code_generator_v8.pm:172: "EventTarget" => 1, Are you sure that ...
7 years, 5 months ago (2013-07-11 11:49:15 UTC) #2
do-not-use
https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm File Source/bindings/scripts/deprecated_code_generator_v8.pm (left): https://codereview.chromium.org/18360008/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm#oldcode172 Source/bindings/scripts/deprecated_code_generator_v8.pm:172: "EventTarget" => 1, On 2013/07/11 11:49:16, haraken wrote: > ...
7 years, 5 months ago (2013-07-11 12:00:33 UTC) #3
haraken
> As you can see from the try bots, it does not cause failures. It ...
7 years, 5 months ago (2013-07-11 12:05:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18360008/3001
7 years, 5 months ago (2013-07-11 12:09:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=12942
7 years, 5 months ago (2013-07-11 13:55:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18360008/18001
7 years, 5 months ago (2013-07-11 14:16:47 UTC) #7
arv (Not doing code reviews)
LGTM
7 years, 5 months ago (2013-07-11 14:28:59 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 15:24:46 UTC) #9
Message was sent while issue was closed.
Change committed as 154010

Powered by Google App Engine
This is Rietveld 408576698