Remove support for [EventTarget] IDL extended attribute

Source/bindings/scripts/deprecated_code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 149 matching lines @@
                          "unsigned long" => 1,
                          "unsigned long long" => 1,
                          "float" => 1,
                          "double" => 1,
                         );
 
 my %nonWrapperTypes = ("CompareHow" => 1,
                        "DOMTimeStamp" => 1,
                        "Dictionary" => 1,
                        "EventListener" => 1,
-                       # FIXME: When EventTarget is an interface and not a mixin, fix this so that
-                       # EventTarget is treated as a wrapper type.
-                       "EventTarget" => 1,

[haraken, 2013/07/11 11:49:16]

Are you sure that we can remove this? Last time I tried to remove this, I hit
some layout test failures. Maybe you have already fixed the issue in the process
of removing [EventTarget].

[do-not-use, 2013/07/11 12:00:33]

As you can see from the try bots, it does not cause failures. It does cause a
small diff in the generated bindings in 2 instances:
http://pastebin.com/zRKaMynQ

Based on the prototype of these 2 methods, the new code seems logical to me but
I may be wrong.

                        "MediaQueryListListener" => 1,
                        "NodeFilter" => 1,
                        "SerializedScriptValue" => 1,
                        "any" => 1,
                       );
 
 my %typedArrayHash = ("ArrayBuffer" => [],
                       "ArrayBufferView" => [],
                       "Uint8Array" => ["unsigned char", "v8::kExternalUnsignedByteArray"],
                       "Uint8ClampedArray" => ["unsigned char", "v8::kExternalPixelArray"],
@@ skipping 492 matching lines @@
 END
 
     if (NeedsOpaqueRootForGC($interface)) {
         $header{classPublic}->add("    static void* opaqueRootForGC(void*, v8::Isolate*);\n");
     }
 
     if (InheritsExtendedAttribute($interface, "ActiveDOMObject")) {
         $header{classPublic}->add("    static ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object>);\n");
     }
 
-    if (InheritsExtendedAttribute($interface, "EventTarget")) {
+    if (InheritsInterface($interface, "EventTarget")) {
         $header{classPublic}->add("    static EventTarget* toEventTarget(v8::Handle<v8::Object>);\n");
     }
 
     if ($interfaceName eq "Window") {
         $header{classPublic}->add(<<END);
     static v8::Handle<v8::ObjectTemplate> GetShadowObjectTemplate(v8::Isolate*, WrapperWorldType);
 END
     }
 
     my @enabledPerContextFunctions;
@@ skipping 278 matching lines @@
     return 0;
 }
 
 sub GetInternalFields
 {
     my $interface = shift;
 
     my @customInternalFields = ();
     # Event listeners on DOM nodes are explicitly supported in the GC controller.
     if (!InheritsInterface($interface, "Node") &&
-        (InheritsExtendedAttribute($interface, "EventTarget") || HasEventListenerAttribute($interface))) {
+        (InheritsInterface($interface, "EventTarget") || HasEventListenerAttribute($interface))) {
         push(@customInternalFields, "eventListenerCacheIndex");
     }
     return @customInternalFields;
 }
 
 sub GenerateHeaderCustomInternalFieldIndices
 {
     my $interface = shift;
     my @customInternalFields = GetInternalFields($interface);
     my $customFieldCounter = 0;
@@ skipping 1798 matching lines @@
 
     my @beforeArgumentList;
     my @afterArgumentList;
 
     my $toActiveDOMObject = "0";
     if (InheritsExtendedAttribute($interface, "ActiveDOMObject")) {
         $toActiveDOMObject = "${v8ClassName}::toActiveDOMObject";
     }
 
     my $toEventTarget = "0";
-    if (InheritsExtendedAttribute($interface, "EventTarget")) {
+    if (InheritsInterface($interface, "EventTarget")) {
         $toEventTarget = "${v8ClassName}::toEventTarget";
     }
 
     AddToImplIncludes("core/page/Frame.h");
     $implementation{nameSpaceWebCore}->add(<<END);
 WrapperTypeInfo ${v8ClassName}Constructor::info = { ${v8ClassName}Constructor::GetTemplate, ${v8ClassName}::derefObject, $toActiveDOMObject, $toEventTarget, 0, ${v8ClassName}::installPerContextPrototypeProperties, 0, WrapperTypeObjectPrototype };
 
 END
 
     my $code = "";
@@ skipping 1048 matching lines @@
     AddToImplIncludes("bindings/v8/V8Binding.h");
     AddToImplIncludes("bindings/v8/V8DOMWrapper.h");
     AddToImplIncludes("core/dom/ContextFeatures.h");
     AddToImplIncludes("core/dom/Document.h");
     AddToImplIncludes("RuntimeEnabledFeatures.h");
     AddToImplIncludes("core/platform/chromium/TraceEvent.h");
 
     AddIncludesForType($interfaceName);
 
     my $toActiveDOMObject = InheritsExtendedAttribute($interface, "ActiveDOMObject") ? "${v8ClassName}::toActiveDOMObject" : "0";
-    my $toEventTarget = InheritsExtendedAttribute($interface, "EventTarget") ? "${v8ClassName}::toEventTarget" : "0";
+    my $toEventTarget = InheritsInterface($interface, "EventTarget") ? "${v8ClassName}::toEventTarget" : "0";
     my $rootForGC = NeedsOpaqueRootForGC($interface) ? "${v8ClassName}::opaqueRootForGC" : "0";
 
     # Find the super descriptor.
     my $parentClass = "";
     my $parentClassTemplate = "";
     if ($interface->parent) {
         my $parent = $interface->parent;
         AddToImplIncludes("V8${parent}.h");
         $parentClass = "V8" . $parent;
         $parentClassTemplate = $parentClass . "::GetTemplate(isolate, currentWorldType)";
@@ skipping 580 matching lines @@
         my $returnValue = $interfaceName eq "MessagePort" ? "0" : "toNative(object)";
         $implementation{nameSpaceWebCore}->add(<<END);
 ActiveDOMObject* ${v8ClassName}::toActiveDOMObject(v8::Handle<v8::Object> object)
 {
     return $returnValue;
 }
 
 END
     }
 
-    if (InheritsExtendedAttribute($interface, "EventTarget")) {
+    if (InheritsInterface($interface, "EventTarget")) {
         $implementation{nameSpaceWebCore}->add(<<END);
 EventTarget* ${v8ClassName}::toEventTarget(v8::Handle<v8::Object> object)
 {
     return toNative(object);
 }
 
 END
     }
 
     if ($interfaceName eq "Window") {
@@ skipping 998 matching lines @@
     if ($arrayOrSequenceType) {
         if (IsRefPtrType($arrayOrSequenceType)) {
             AddIncludesForType($arrayOrSequenceType);
         }
         return "${indent}v8SetReturnValue(${getHolderContainer}, v8Array($nativeValue, $getIsolate));" if $isReturnValue;
         return "$indent$receiver v8Array($nativeValue, $getIsolate);";
     }
 
     AddIncludesForType($type);
 
-    if (IsDOMNodeType($type) || $type eq "EventTarget") {

[do-not-use, 2013/07/11 11:45:31]

This if case is not needed because it does exactly the same thing as the code
below (line 5514+). The only impact is potentially useless wtf header include.

-      if ($getScriptWrappable) {
-          # FIXME: Use safe handles
-          return "${indent}v8SetReturnValue(${getHolderContainer}, toV8Fast${forMainWorldSuffix}($nativeValue$getHolderContainerArg$getScriptWrappableArg));" if $isReturnValue;
-          return "$indent$receiver toV8Fast${forMainWorldSuffix}($nativeValue$getHolderContainerArg$getScriptWrappableArg);";
-      }
-      # FIXME: Use safe handles
-      return "${indent}v8SetReturnValue(${getHolderContainer}, toV8($nativeValue, $getCreationContext, $getIsolate));" if $isReturnValue;
-      return "$indent$receiver toV8($nativeValue, $getCreationContext, $getIsolate);";
-    }
-
     if ($type eq "SerializedScriptValue") {
         AddToImplIncludes("$type.h");
         my $returnValue = "$nativeValue ? $nativeValue->deserialize() : v8::Handle<v8::Value>(v8::Null($getIsolate))";
         return "${indent}v8SetReturnValue(${getHolderContainer}, $returnValue);" if $isReturnValue;
         return "$indent$receiver $returnValue;";
     }
 
-    AddToImplIncludes("wtf/RefCounted.h");
     AddToImplIncludes("wtf/RefPtr.h");
     AddToImplIncludes("wtf/GetPtr.h");
 
     if ($getScriptWrappable) {
         # FIXME: Use safe handles
         return "${indent}v8SetReturnValue(${getHolderContainer}, toV8Fast${forMainWorldSuffix}($nativeValue$getHolderContainerArg$getScriptWrappableArg));" if $isReturnValue;
         return "$indent$receiver toV8Fast${forMainWorldSuffix}($nativeValue$getHolderContainerArg$getScriptWrappableArg);";
     }
     # FIXME: Use safe handles
     return "${indent}v8SetReturnValue(${getHolderContainer}, toV8($nativeValue, $getCreationContext, $getIsolate));" if $isReturnValue;
@@ skipping 538 matching lines @@
         if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
             $found = 1;
         }
         return 1 if $found;
     }, 0);
 
     return $found;
 }
 
 1;