S390: Impl Left/Right Logical/Arith Shift Pair

S390: Impl Left/Right Logical/Arith Shift Pair

Implement Left/Right Logical/Arithmetic Shift Pair operations for s390

R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com
BUG=

Committed: https://crrev.com/b7eb0cf9f49b49b4db27b845682ae2f841c509de
Cr-Commit-Position: refs/heads/master@{#35087}

[john.yan, 2016-03-28 20:05:09]

PTAL

[john.yan, 2016-03-28 20:05:14]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 20:05:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835973003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835973003/1

[JoranSiu, 2016-03-28 20:10:20]

On 2016/03/28 20:05:25, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1835973003/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1835973003/1

@john.yan, SRDL/SRDA seems to be missing in disasm + simulator?

[john.yan, 2016-03-28 20:11:00]

On 2016/03/28 20:10:20, JoranSiu wrote:
> On 2016/03/28 20:05:25, commit-bot: I haz the power wrote:
> > Dry run: CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1835973003/1
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1835973003/1
> 
> @john.yan, SRDL/SRDA seems to be missing in disasm + simulator?

They are already there.

[JoranSiu, 2016-03-28 20:19:39]

https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc
File src/s390/disasm-s390.cc (right):

https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc#new...
src/s390/disasm-s390.cc:973: case SRDA:
Can you update SRDA/SRDL the Format to be consistent with SLDL above?  i.e.
'd1('r3)

[commit-bot: I haz the power, 2016-03-28 20:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 20:25:16]

Dry run: This issue passed the CQ dry run.

[john.yan, 2016-03-28 22:18:29]

https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc
File src/s390/disasm-s390.cc (right):

https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc#new...
src/s390/disasm-s390.cc:973: case SRDA:
On 2016/03/28 20:19:39, JoranSiu wrote:
> Can you update SRDA/SRDL the Format to be consistent with SLDL above?  i.e.
> 'd1('r3)

Acknowledged.

[john.yan, 2016-03-28 22:19:04]

On 2016/03/28 20:19:39, JoranSiu wrote:
> https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc
> File src/s390/disasm-s390.cc (right):
> 
>
https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc#new...
> src/s390/disasm-s390.cc:973: case SRDA:
> Can you update SRDA/SRDL the Format to be consistent with SLDL above?  i.e.
> 'd1('r3)

Updated.

[JoranSiu, 2016-03-28 22:30:54]

On 2016/03/28 22:19:04, john.yan wrote:
> On 2016/03/28 20:19:39, JoranSiu wrote:
> > https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc
> > File src/s390/disasm-s390.cc (right):
> > 
> >
>
https://codereview.chromium.org/1835973003/diff/1/src/s390/disasm-s390.cc#new...
> > src/s390/disasm-s390.cc:973: case SRDA:
> > Can you update SRDA/SRDL the Format to be consistent with SLDL above?  i.e.
> > 'd1('r3)
> 
> Updated.

lgtm

[john.yan, 2016-03-28 22:36:45]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-03-28 22:36:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835973003/20001

[commit-bot: I haz the power, 2016-03-28 22:58:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-28 23:00:18]

Description was changed from

==========
S390: Impl Left/Right Logical/Arith Shift Pair

Implement Left/Right Logical/Arithmetic Shift Pair operations for s390

R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

to

==========
S390: Impl Left/Right Logical/Arith Shift Pair

Implement Left/Right Logical/Arithmetic Shift Pair operations for s390

R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com
BUG=

Committed: https://crrev.com/b7eb0cf9f49b49b4db27b845682ae2f841c509de
Cr-Commit-Position: refs/heads/master@{#35087}
==========

[commit-bot: I haz the power, 2016-03-28 23:00:18]

Patchset 2 (id:??) landed as
https://crrev.com/b7eb0cf9f49b49b4db27b845682ae2f841c509de
Cr-Commit-Position: refs/heads/master@{#35087}