Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1835943003: [DevTools] Use main frame when searching/creating DevToolsAgentHost. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, pfeldman, devtools-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Use main frame when searching/creating DevToolsAgentHost. It was possible to create DTAH for cross-process child frame and then get it back when asking for WebContents' DTAH. Instead, we go for main frame explicitly. This bug only manifested with context menu on cross-process iframe, since we have both per-WebContents and per-frame methods. Ideally, we'd use either one or another, but we need per-frame one now, while per-WebContents is the way to go when cross-process frames would be inspected in the same DevTools window. BUG=598005 TEST=SitePerProcessDevToolsBrowserTest.AgentHostForPageEqualsOneForMainFrame Committed: https://crrev.com/0fe3f402fe308f7b34317be38590d23bad3c84bc Cr-Commit-Position: refs/heads/master@{#383646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +8 lines, -20 lines 0 comments Download
M content/browser/devtools/site_per_process_devtools_browsertest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look?
4 years, 8 months ago (2016-03-28 19:27:56 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-03-29 00:25:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835943003/1
4 years, 8 months ago (2016-03-29 00:26:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 01:25:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 01:26:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fe3f402fe308f7b34317be38590d23bad3c84bc
Cr-Commit-Position: refs/heads/master@{#383646}

Powered by Google App Engine
This is Rietveld 408576698