Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 1835943003: [DevTools] Use main frame when searching/creating DevToolsAgentHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/site_per_process_devtools_browsertest.cc
diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc
index 04d244d276b2bccff67196957f4618ee85e83131..e3c3cf222bc3cf1cbcb1bb12675ceaebf7e332e2 100644
--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc
+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc
@@ -168,4 +168,36 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest, AgentHostForFrames) {
EXPECT_NE(page_agent.get(), child_frame_agent.get());
}
+IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
+ AgentHostForPageEqualsOneForMainFrame) {
+ host_resolver()->AddRule("*", "127.0.0.1");
+ GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
+ NavigateToURL(shell(), main_url);
+
+ // It is safe to obtain the root frame tree node here, as it doesn't change.
+ FrameTreeNode* root =
+ static_cast<WebContentsImpl*>(shell()->web_contents())->
+ GetFrameTree()->root();
+ FrameTreeNode* child = root->child_at(0);
+
+ // Load cross-site page into iframe.
+ GURL::Replacements replace_host;
+ GURL cross_site_url(embedded_test_server()->GetURL("/title2.html"));
+ replace_host.SetHostStr("foo.com");
+ cross_site_url = cross_site_url.ReplaceComponents(replace_host);
+ NavigateFrameToURL(child, cross_site_url);
+
+ // First ask for child frame, then for main frame.
+ scoped_refptr<DevToolsAgentHost> child_frame_agent =
+ DevToolsAgentHost::GetOrCreateFor(child->current_frame_host());
+ scoped_refptr<DevToolsAgentHost> main_frame_agent =
+ DevToolsAgentHost::GetOrCreateFor(root->current_frame_host());
+ EXPECT_NE(main_frame_agent.get(), child_frame_agent.get());
+
+ // Agent for web contents should be the the main frame's one.
+ scoped_refptr<DevToolsAgentHost> page_agent =
+ DevToolsAgentHost::GetOrCreateFor(shell()->web_contents());
+ EXPECT_EQ(page_agent.get(), main_frame_agent.get());
+}
+
} // namespace content
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698