Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1835913002: [Merge M50] [Downloads] Retain a BlobDataHandle in DownloadUrlParameters. (Closed)

Created:
4 years, 8 months ago by asanka
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Merge M50] [Downloads] Retain a BlobDataHandle in DownloadUrlParameters. This allows a caller to extend the lifetime of a blob until the downloads / resource loader subsystems take over. Without this, an unfortunately timed revokeObjectURL() call from the originating page may invalidate the URL before the download has a chance to start the associated download request. BUG=595305 Review URL: https://codereview.chromium.org/1829413002 Cr-Commit-Position: refs/heads/master@{#383370} (cherry picked from commit 6150c52a037d3b05eeac0faaf792ab0203b5580f) Committed: https://chromium.googlesource.com/chromium/src/+/58242aeb11363fe0436724aefdc56faaf53321e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M content/browser/download/download_browsertest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/public/browser/download_url_parameters.h View 4 chunks +20 lines, -0 lines 0 comments Download
A content/test/data/download/download-attribute-blob.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + content/test/data/download/download-attribute-blob.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
asanka
4 years, 8 months ago (2016-03-28 15:40:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58242aeb11363fe0436724aefdc56faaf53321e4.

Powered by Google App Engine
This is Rietveld 408576698