Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1829413002: [Downloads] Retain a BlobDataHandle in DownloadUrlParameters. (Closed)

Created:
4 years, 9 months ago by asanka
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
asanka, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Retain a BlobDataHandle in DownloadUrlParameters. This allows a caller to extend the lifetime of a blob until the downloads / resource loader subsystems take over. Without this, an unfortunately timed revokeObjectURL() call from the originating page may invalidate the URL before the download has a chance to start the associated download request. BUG=595305 Committed: https://crrev.com/6150c52a037d3b05eeac0faaf792ab0203b5580f Cr-Commit-Position: refs/heads/master@{#383370}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M content/browser/download/download_browsertest.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/public/browser/download_url_parameters.h View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
A content/test/data/download/download-attribute-blob.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A + content/test/data/download/download-attribute-blob.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
asanka
jam: PTAL?
4 years, 9 months ago (2016-03-25 19:20:56 UTC) #4
jam
lgtm
4 years, 9 months ago (2016-03-25 19:31:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829413002/40001
4 years, 9 months ago (2016-03-25 20:10:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-25 21:41:13 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:45:41 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6150c52a037d3b05eeac0faaf792ab0203b5580f
Cr-Commit-Position: refs/heads/master@{#383370}

Powered by Google App Engine
This is Rietveld 408576698