Added check for behavior feature existense

Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936
Committed: https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9
Cr-Commit-Position: refs/heads/master@{#387565}

[matthewtff.asm, 2016-03-28 07:15:14]

We receive crashes at
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...
due to unavailable behavior feature. My invstigation led me to
http://crbug.com/176381 (See https://chromiumcodereview.appspot.com/12255041
and
https://chromiumcodereview.appspot.com/12326054)

I believe some checks are missing since a behavior json file has been
introduced. Could you take a look please?

P. S. I couldn't find appropriate bug(probably due to security it's marked as
internal only)

[matthewtff.asm, 2016-03-28 07:15:31]

Description was changed from

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=
==========

to

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=
==========

[matthewtff.asm, 2016-03-28 07:15:31]

matthewtff@yandex-team.ru changed reviewers:
+ benwells@chromium.org

[matthewtff.asm, 2016-04-06 12:22:41]

Gentle ping

[benwells, 2016-04-12 00:14:50]

On 2016/04/06 12:22:41, matthewtff.asm wrote:
> Gentle ping

Sorry about that. For some reason I missed the first email, and this second one
came as I was going on leave.

The bug you've linked to has been fixed for a couple of years. Are there still
outstanding problems?

[matthewtff.asm, 2016-04-12 09:08:33]

On 2016/04/12 00:14:50, benwells wrote:
> Sorry about that. For some reason I missed the first email, and this second
one
> came as I was going on leave.

No problem, thanks for your time.

> The bug you've linked to has been fixed for a couple of years. Are there still
> outstanding problems?

Yeah, there is new, but similar problem. The problems in bug fixed crashes while
parsing _api_features.json,
_permission_features.json and _manifest_features.json, but not for newly added
_behavior_features.json.

So here're fixes that allow browser to continue work(not crash) if JSONReader
failed to parse _behavior_features.json

[benwells, 2016-04-13 03:04:40]

On 2016/04/12 09:08:33, matthewtff.asm wrote:
> On 2016/04/12 00:14:50, benwells wrote:
> > Sorry about that. For some reason I missed the first email, and this second
> one
> > came as I was going on leave.
> 
> No problem, thanks for your time.
> 
> > The bug you've linked to has been fixed for a couple of years. Are there
still
> > outstanding problems?
> 
> Yeah, there is new, but similar problem. The problems in bug fixed crashes
while
> parsing _api_features.json,
> _permission_features.json and _manifest_features.json, but not for newly added
> _behavior_features.json.
> 
> So here're fixes that allow browser to continue work(not crash) if JSONReader
> failed to parse _behavior_features.json

Could you file a new bug, with a reproduction, and link this Cl to that bug (via
the BUG= line in the description).

[matthewtff.asm, 2016-04-13 06:38:31]

On 2016/04/13 03:04:40, benwells wrote:
> On 2016/04/12 09:08:33, matthewtff.asm wrote:
> > On 2016/04/12 00:14:50, benwells wrote:
> > > Sorry about that. For some reason I missed the first email, and this
second
> > one
> > > came as I was going on leave.
> > 
> > No problem, thanks for your time.
> > 
> > > The bug you've linked to has been fixed for a couple of years. Are there
> still
> > > outstanding problems?
> > 
> > Yeah, there is new, but similar problem. The problems in bug fixed crashes
> while
> > parsing _api_features.json,
> > _permission_features.json and _manifest_features.json, but not for newly
added
> > _behavior_features.json.
> > 
> > So here're fixes that allow browser to continue work(not crash) if
JSONReader
> > failed to parse _behavior_features.json
> 
> Could you file a new bug, with a reproduction, and link this Cl to that bug
(via
> the BUG= line in the description).

I certainly could file a new bug, but there's no way to reproduce it locally -
it's a flaky
fail of JSONReader(end users could have broken resource files, I don't know for
sure
how that happens).

[matthewtff.asm, 2016-04-13 06:58:36]

Description was changed from

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=
==========

to

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936
==========

[benwells, 2016-04-14 06:36:15]

Thanks for adding the bug!

https://codereview.chromium.org/1835863002/diff/1/extensions/common/features/...
File extensions/common/features/feature_provider.h (right):

https://codereview.chromium.org/1835863002/diff/1/extensions/common/features/...
extensions/common/features/feature_provider.h:16: class Extension;
It's nice that this file doesn't depend on Extension. It's also a bit weird now
that the behavior features don't follow the same pattern of the other features.

Can you revert the changes in this file, but ad a comment above Get*Feature that
the features can be null if JSON files are corrupted, and just put null checks
in the callsites to GetBehaviorFeature?

[matthewtff.asm, 2016-04-14 16:16:46]

On 2016/04/14 06:36:15, benwells wrote:
> Can you revert the changes in this file, but ad a comment above Get*Feature
that
> the features can be null if JSON files are corrupted, and just put null checks
> in the callsites to GetBehaviorFeature?

Done. Also updated a couple callsites of GetAPIFeature(I think these also crash
time-to-time,
but very rarely due to uncommon code path).

[benwells, 2016-04-15 05:41:58]

lgtm

[matthewtff.asm, 2016-04-15 09:03:05]

The CQ bit was checked by matthewtff@yandex-team.ru

[commit-bot: I haz the power, 2016-04-15 09:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1835863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1835863002/20001

[commit-bot: I haz the power, 2016-04-15 09:57:07]

Description was changed from

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936
==========

to

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936
==========

[commit-bot: I haz the power, 2016-04-15 09:57:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 10:02:01]

Description was changed from

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936
==========

to

==========
Added check for behavior feature existense

Sometimes JSONReader fails to read json from resources(or resources are broken).
So add some error checking to prevent browser crash in such cases. See
https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details

BUG=602936

Committed: https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9
Cr-Commit-Position: refs/heads/master@{#387565}
==========

[commit-bot: I haz the power, 2016-04-15 10:02:02]

Patchset 2 (id:??) landed as
https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9
Cr-Commit-Position: refs/heads/master@{#387565}