chrome/browser/ui/extensions/application_launch.cc - Issue 1835863002: Added check for behavior feature existense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 1835863002: Added check for behavior feature existense (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make Get*Feature return |nullptr| instead crash if feature is missing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index f2625ff966373827ab61f031d755782d6172fb37..47a3f477ec8aa457c903d46c5f9ee8f47a520356 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -410,5 +410,5 @@ WebContents* OpenAppShortcutWindow(Profile* profile,

bool CanLaunchViaEvent(const extensions::Extension* extension) {

const extensions::Feature* feature =

extensions::FeatureProvider::GetAPIFeature("app.runtime");

- return feature->IsAvailableToExtension(extension).is_available();

+ return feature && feature->IsAvailableToExtension(extension).is_available();

}

« no previous file with comments | « chrome/browser/extensions/extension_util.cc ('k') | chrome/common/extensions/sync_helper.cc » ('j') | no next file with comments »