Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1835833005: Don't squash layers with non-translation transforms. (Closed)

Created:
4 years, 8 months ago by chrishtr
Modified:
4 years, 8 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't squash layers with non-translation transforms. Otherwise it makes it too difficult to compute interest rects for them. BUG=594177 Committed: https://crrev.com/9174f59cb6a861a48f89aff2fd89d2f07a832e0a Cr-Commit-Position: refs/heads/master@{#384058}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages

Total messages: 18 (9 generated)
chrishtr
4 years, 8 months ago (2016-03-29 22:29:58 UTC) #3
Xianzhu
lgtm
4 years, 8 months ago (2016-03-29 22:32:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835833005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835833005/40001
4 years, 8 months ago (2016-03-29 22:32:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/23042)
4 years, 8 months ago (2016-03-29 23:46:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835833005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835833005/60001
4 years, 8 months ago (2016-03-30 03:12:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196023) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, ...
4 years, 8 months ago (2016-03-30 09:13:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835833005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835833005/60001
4 years, 8 months ago (2016-03-30 16:13:44 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-03-30 19:38:22 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:05:33 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9174f59cb6a861a48f89aff2fd89d2f07a832e0a
Cr-Commit-Position: refs/heads/master@{#384058}

Powered by Google App Engine
This is Rietveld 408576698