third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp - Issue 1835833005: Don't squash layers with non-translation transforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 1835833005: Don't squash layers with non-translation transforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-with-scale-transform-expected.txt ('k') | third_party/WebKit/Source/platform/graphics/SquashingDisallowedReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

index c832901a19bfd2c854b3a52cb86fdacda1783c87..d692b0dcf15a86bc342f241a6a78d274c26505c2 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

@@ -166,6 +166,9 @@ SquashingDisallowedReasons CompositingLayerAssigner::getReasonsPreventingSquashi

if (layer->transformAncestor() != squashingLayer.transformAncestor())

return SquashingDisallowedReasonTransformAncestorMismatch;

+ if (layer->transform() && !layer->transform()->isIdentityOrTranslation())

+ return SquashingDisallowedReasonNonTranslationTransform;

if (layer->renderingContextRoot() != squashingLayer.renderingContextRoot())

return SquashingDisallowedReasonRenderingContextMismatch;