Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1835813003: Use NV glsl shader compiler for Vulkan (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cacheHash
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use NV glsl shader compiler for Vulkan The nvidia direct glsl shader compiler seems to perform much better than using shaderc to compile to spir-v first. This change also includes a change to prefer host cached memory for buffers. Having cached buffers signifcantly improves performance whenever we need to do buffer reads and writes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835813003 Committed: https://skia.googlesource.com/skia/+/c5ec1408298510410270ea67e895570ccfa76e54

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -38 lines) Patch
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +12 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkCaps.h View 4 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 2 1 chunk +36 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 8 months ago (2016-03-28 17:46:52 UTC) #3
jvanverth1
lgtm
4 years, 8 months ago (2016-03-28 18:17:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835813003/40001
4 years, 8 months ago (2016-03-28 18:57:53 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 19:14:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c5ec1408298510410270ea67e895570ccfa76e54

Powered by Google App Engine
This is Rietveld 408576698