Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1835783002: DevTools: simplify WI.FormattedContentBuilder (Closed)

Created:
4 years, 9 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: simplify WI.FormattedContentBuilder The WI.FormattedContentBuilder has a functionality that preserves the originaly entered new lines. This patch removes this functionality in order to simplify the internal code. As of today, nobody really benefits from the functionality. The pretty-printers should maximize for beauty, thus should not respect originally entered newlines. BUG=none R=dgozman, pfeldman Committed: https://crrev.com/a3aa8c5a90ecf364c444e75fa90044fa18c5f165 Cr-Commit-Position: refs/heads/master@{#383598}

Patch Set 1 #

Patch Set 2 : rebaseline tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -48 lines) Patch
M third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-1-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-4.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-2-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-css-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-5-expected.txt View 4 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/FormattedContentBuilder.js View 3 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/HTMLFormatter.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/IdentityFormatter.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptFormatter.js View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
lushnikov
ptal
4 years, 9 months ago (2016-03-26 20:50:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835783002/1
4 years, 9 months ago (2016-03-26 20:51:04 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/202499)
4 years, 9 months ago (2016-03-26 21:54:04 UTC) #5
dgozman
Looks like this doesn't work?
4 years, 8 months ago (2016-03-28 16:42:58 UTC) #6
lushnikov
rebaselined tests; please take another look.
4 years, 8 months ago (2016-03-28 21:29:41 UTC) #7
lushnikov
rebaselined tests; please take another look.
4 years, 8 months ago (2016-03-28 21:29:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835783002/20001
4 years, 8 months ago (2016-03-28 21:30:13 UTC) #10
dgozman
lgtm
4 years, 8 months ago (2016-03-28 22:32:57 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 23:00:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835783002/20001
4 years, 8 months ago (2016-03-28 23:05:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 23:12:36 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:13:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3aa8c5a90ecf364c444e75fa90044fa18c5f165
Cr-Commit-Position: refs/heads/master@{#383598}

Powered by Google App Engine
This is Rietveld 408576698