third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js - Issue 1835783002: DevTools: simplify WI.FormattedContentBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js

Issue 1835783002: DevTools: simplify WI.FormattedContentBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaseline tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-5-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/formatter_worker/FormattedContentBuilder.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js

diff --git a/third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js b/third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js

index 5743e0deb583ba6a9354772beda0e18f997a0bbb..3476327b90b092d2e41802884529879bd07c5746 100644

--- a/third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js

+++ b/third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js

@@ -59,14 +59,11 @@ WebInspector.CSSFormatter.prototype = {

* @param {string} token

* @param {?string} type

* @param {number} startPosition

- * @param {number} endPosition

- _tokenCallback: function(token, type, startPosition, endPosition)

+ _tokenCallback: function(token, type, startPosition)

{

startPosition += this._fromOffset;

- endPosition += this._fromOffset;

var startLine = this._lineEndings.lowerBound(startPosition);

- var endLine = this._lineEndings.lowerBound(endPosition);

if (startLine !== this._lastLine)

this._state.eatWhitespace = true;

if (/^property/.test(type) && !this._state.inPropertyValue)

@@ -94,7 +91,7 @@ WebInspector.CSSFormatter.prototype = {

this._state.afterClosingBrace = true;

this._state.inPropertyValue = false;

} else if (token === ":" && !this._state.inPropertyValue && this._state.seenProperty) {

- this._builder.addToken(token, startPosition, startLine, endLine);

+ this._builder.addToken(token, startPosition);

this._builder.addSoftSpace();

this._state.eatWhitespace = true;

this._state.inPropertyValue = true;

@@ -102,13 +99,13 @@ WebInspector.CSSFormatter.prototype = {

return;

} else if (token === "{") {

this._builder.addSoftSpace();

- this._builder.addToken(token, startPosition, startLine, endLine);

+ this._builder.addToken(token, startPosition);

this._builder.addNewLine();

this._builder.increaseNestingLevel();

return;

}

- this._builder.addToken(token, startPosition, startLine, endLine);

+ this._builder.addToken(token, startPosition);

if (type === "comment" && !this._state.inPropertyValue && !this._state.seenProperty)

this._builder.addNewLine();