third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1835773002: Rename AtomicString::string() to AtomicString::getString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1835773002: Rename AtomicString::string() to AtomicString::getString(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index 148395bc9eebfdcd8bf2a5e538c86c02d6c05062..e06a4443358e3f0116c7443633c016991af96fd6 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -139,7 +139,7 @@ static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca

bool HTMLTextFormControlElement::isPlaceholderEmpty() const

{

const AtomicString& attributeValue = fastGetAttribute(placeholderAttr);

- return attributeValue.string().find(isNotLineBreak) == kNotFound;

+ return attributeValue.getString().find(isNotLineBreak) == kNotFound;

}

bool HTMLTextFormControlElement::placeholderShouldBeVisible() const