Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1835703002: Remove FX_DWORD from XFA, part 2 (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_DWORD from XFA, part 2 Some headers were missed in the previous CL. Committed: https://pdfium.googlesource.com/pdfium/+/deee3d2ee201d62e7ef41e7d8378d7f52e057a9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+746 lines, -746 lines) Patch
M xfa/fde/css/fde_css.h View 6 chunks +8 lines, -8 lines 0 comments Download
M xfa/fde/css/fde_csscache.h View 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 10 chunks +42 lines, -42 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 6 chunks +10 lines, -10 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_iterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fde/fde_render.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_visualset.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fee/fde_txtedtengine.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fee/fde_txtedtpage.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fee/ifde_txtedtengine.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/fgas/crt/fgas_utils.h View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/font/fgas_font.h View 8 chunks +30 lines, -30 lines 0 comments Download
M xfa/fgas/font/fgas_fontutils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 3 chunks +6 lines, -6 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 8 chunks +33 lines, -33 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 5 chunks +9 lines, -9 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.h View 5 chunks +11 lines, -11 lines 0 comments Download
M xfa/fgas/localization/fgas_localeimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/xml/fgas_sax.h View 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fgas/xml/fgas_sax_imp.h View 5 chunks +14 lines, -14 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.h View 3 chunks +10 lines, -10 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.h View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.h View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.h View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_caret.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_combobox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_datetimepicker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_listbox.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_event.h View 4 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/core/cfwl_message.h View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fwl/core/cfwl_note.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/cfwl_themepart.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_themetext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_widgetimpproperties.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_gridimp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_targetimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 6 chunks +14 lines, -14 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_adapterwidgetmgr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_notedriver.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_target.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_themeprovider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_timer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_widgetmgr.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widgetmgrdelegate.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/include/ifwl_adaptertimermgr.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 2 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimage.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.h View 5 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpath.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffsignature.h View 1 chunk +13 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_fftext.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.h View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.h View 4 chunks +19 lines, -19 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.h View 3 chunks +18 lines, -18 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 7 chunks +15 lines, -15 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_error.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.h View 12 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_lexer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.h View 18 chunks +24 lines, -24 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_docdata.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_doclayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.h View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 8 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxgraphics/include/cfx_graphics.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/barcode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/caret.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/combobox.h View 5 chunks +8 lines, -8 lines 0 comments Download
M xfa/include/fwl/lightwidget/datetimepicker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/listbox.h View 5 chunks +7 lines, -7 lines 0 comments Download
M xfa/include/fwl/lightwidget/scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/theme.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/include/fwl/lightwidget/widget.h View 5 chunks +12 lines, -12 lines 0 comments Download
M xfa/include/fwl/theme/carettp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/theme/checkboxtp.h View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/include/fwl/theme/comboboxtp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/theme/formtp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/include/fwl/theme/listboxtp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/theme/monthcalendartp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/include/fwl/theme/pushbuttontp.h View 1 chunk +12 lines, -12 lines 0 comments Download
M xfa/include/fwl/theme/scrollbartp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/include/fwl/theme/utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 6 chunks +17 lines, -17 lines 0 comments Download
M xfa/include/fxfa/fxfa.h View 10 chunks +30 lines, -30 lines 0 comments Download
M xfa/include/fxfa/fxfa_basic.h View 6 chunks +14 lines, -14 lines 0 comments Download
M xfa/include/fxfa/fxfa_objectacc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_widget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Oliver, next one.
4 years, 9 months ago (2016-03-25 21:10:37 UTC) #2
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-25 21:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835703002/1
4 years, 9 months ago (2016-03-25 21:17:06 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:39:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/deee3d2ee201d62e7ef41e7d8378d7f52e05...

Powered by Google App Engine
This is Rietveld 408576698