Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1835603002: Clean up gn VC++ linker settings (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up gn VC++ linker settings /fastfail and /maxilksize:0x7ff00000 were added to the wrong place in crrev.com/1816333002 and need to be moved/merged. Also, the mini_installer link command removes executable_config (which suppresses LNK4199 warnings) and then triggers those warnings so that suppression needs to be added back in. The /maxilksize argument is also changed to be consistent and to avoid duplication. This doesn't change build behavior at all, it just suppresses some warnings and tidies up the configuration. Committed: https://crrev.com/304172167717e13b6579ecfb7e3fc63338de66ac Cr-Commit-Position: refs/heads/master@{#383399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
4 years, 9 months ago (2016-03-25 18:48:24 UTC) #3
brettw
lgtm
4 years, 9 months ago (2016-03-25 22:11:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835603002/1
4 years, 9 months ago (2016-03-25 22:24:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:11:33 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:13:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/304172167717e13b6579ecfb7e3fc63338de66ac
Cr-Commit-Position: refs/heads/master@{#383399}

Powered by Google App Engine
This is Rietveld 408576698