Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4229)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/win/BUILD.gn

Issue 1835603002: Clean up gn VC++ linker settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/installer/mini_installer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index bf1e613c92a74d5b744f0d90f8156d6fdcedd096..7945cfc10066c4a1d15bdc649d37ab67b84ea6d7 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -244,7 +244,11 @@ config("common_linker_setup") {
# LINK : fatal error LNK1248: image size (80000000)
# exceeds maximum allowable size (80000000)
# which started happening more regularly after VS2013 Update 4.
- "/maxilksize:2147483647",
+ # Needs to be a bit lower for VS2015, or else errors out.
+ "/maxilksize:0x7ff00000",
+
+ # Tell the linker to crash on failures.
+ "/fastfail",
]
# ASLR makes debugging with windbg difficult because Chrome.exe and
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/installer/mini_installer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698