Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1835573005: [Merge M50] aw: Remove WindowAndroid caching (Closed)

Created:
4 years, 9 months ago by boliu
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Merge M50] aw: Remove WindowAndroid caching Caching sCachedWindowAndroid is incorrect since it is possible for the one Application context to be wrapped differently. There is no point in caching ActivityWindowAndroid either due to the way ResourcesContextWrapperFactory works. So remove caching altogether and always create a new WindowAndroid instance. BUG=597526 Review URL: https://codereview.chromium.org/1831373003 Cr-Commit-Position: refs/heads/master@{#383408} (cherry picked from commit d1c68aa675d8d5586e2cda7df1ad56d5e4129e59) Committed: https://chromium.googlesource.com/chromium/src/+/030335581832763bf521dbe3e5cf7cd87b6d5f94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
boliu
4 years, 9 months ago (2016-03-26 01:19:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
030335581832763bf521dbe3e5cf7cd87b6d5f94.

Powered by Google App Engine
This is Rietveld 408576698