Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1831373003: aw: Remove WindowAndroid caching (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Remove WindowAndroid caching Caching sCachedWindowAndroid is incorrect since it is possible for the one Application context to be wrapped differently. There is no point in caching ActivityWindowAndroid either due to the way ResourcesContextWrapperFactory works. So remove caching altogether and always create a new WindowAndroid instance. BUG=597526 Committed: https://crrev.com/d1c68aa675d8d5586e2cda7df1ad56d5e4129e59 Cr-Commit-Position: refs/heads/master@{#383408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
boliu
ptal
4 years, 8 months ago (2016-03-25 20:48:51 UTC) #2
sgurun-gerrit only
On 2016/03/25 20:48:51, boliu wrote: > ptal make sense. s/ways create/always create/ lgtm
4 years, 8 months ago (2016-03-25 22:59:34 UTC) #3
boliu
On 2016/03/25 22:59:34, sgurun wrote: > On 2016/03/25 20:48:51, boliu wrote: > > ptal > ...
4 years, 8 months ago (2016-03-25 23:02:43 UTC) #5
boliu
On 2016/03/25 23:02:43, boliu wrote: > On 2016/03/25 22:59:34, sgurun wrote: > > On 2016/03/25 ...
4 years, 8 months ago (2016-03-25 23:03:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831373003/1
4 years, 8 months ago (2016-03-25 23:03:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-25 23:39:06 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-25 23:42:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c68aa675d8d5586e2cda7df1ad56d5e4129e59
Cr-Commit-Position: refs/heads/master@{#383408}

Powered by Google App Engine
This is Rietveld 408576698