Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1835563002:
Turn off Discardable scaled image cache (Closed)
|
Created:
4 years, 9 months ago by robertphillips Modified:
4 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionTurn off Discardable scaled image cache
This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android and Ubuntu for the ugamsolutions skp (and others).
I guess the real question is, since it isn't crashing, do we want to leave it enabled?
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835563002
Committed: https://skia.googlesource.com/skia/+/ff6595286c0cd458979bb465078309543c68210a
Patch Set 1 #Patch Set 2 : Update comment #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Turn off Discardable scaled image cache ========== to ========== Turn off Discardable scaled image cache GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Turn off Discardable scaled image cache GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Turn off Discardable scaled image cache This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android for the ugamsolutions skp. I guess the real question is, since it isn't crashing, do we want to leave it enabled? GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com, reed@google.com
Description was changed from ========== Turn off Discardable scaled image cache This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android for the ugamsolutions skp. I guess the real question is, since it isn't crashing, do we want to leave it enabled? GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Turn off Discardable scaled image cache This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android and Ubuntu for the ugamsolutions skp (and others). I guess the real question is, since it isn't crashing, do we want to leave it enabled? GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
I believe this flag is not really about crashing bots, but about wanting to test both configurations of Skia: with and without. Chrome uses a discardable cache (albeit with a different discardable backend) but android/mozilla/flutter do not. I think I vote to land this CL (but update the comment) and we can decide later how we might test both versions more regularly.
On 2016/03/25 14:03:01, robertphillips wrote: Sounds like questions for reed@. I don't know much about this.
mtklein@google.com changed reviewers: + mtklein@google.com
If we flip this, we may want to alos invert this bot, which has been using this flag to test like Chrome does: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX...
Okay - I've updated the comment
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835563002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835563002/20001
Message was sent while issue was closed.
Description was changed from ========== Turn off Discardable scaled image cache This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android and Ubuntu for the ugamsolutions skp (and others). I guess the real question is, since it isn't crashing, do we want to leave it enabled? GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Turn off Discardable scaled image cache This change accidentally slipped into the checked in version of https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface). It is the reason why we're seeing performance improvements on Android and Ubuntu for the ugamsolutions skp (and others). I guess the real question is, since it isn't crashing, do we want to leave it enabled? GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/ff6595286c0cd458979bb465078309543c68210a ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/ff6595286c0cd458979bb465078309543c68210a |
