gyp/common.gypi - Issue 1835563002: Turn off Discardable scaled image cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/common.gypi

Issue 1835563002: Turn off Discardable scaled image cache (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/common.gypi

diff --git a/gyp/common.gypi b/gyp/common.gypi

index f20c346571a8ba3d81decb20e863cf6498e0156f..ae6dd628cc2fb268e0aad9066b940f984a3bbf19 100644

--- a/gyp/common.gypi

+++ b/gyp/common.gypi

@@ -16,7 +16,9 @@

'SK_GAMMA_SRGB',

'SK_GAMMA_APPLY_TO_A8',

'QT_NO_KEYWORDS',

- 'SK_USE_DISCARDABLE_SCALEDIMAGECACHE', # TODO(reed): Re-enable when tests don't crash with this.

+ # The discardable resource cache is tested via a special bot. This is

+ # disabled here so we test the non-discardable use case.

+ # 'SK_USE_DISCARDABLE_SCALEDIMAGECACHE',

# Validate the 'skia_os' setting against 'OS', because only certain

« no previous file with comments | « no previous file | no next file » | no next file with comments »