Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: mash/wm/public/interfaces/shelf_layout.mojom

Issue 1835403002: Support additional mash shelf alignments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mash/wm/public/interfaces/BUILD.gn ('k') | mash/wm/root_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/wm/public/interfaces/shelf_layout.mojom
diff --git a/mash/wm/public/interfaces/shelf_layout.mojom b/mash/wm/public/interfaces/shelf_layout.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..694fe11d5f08dd756c4d9700c7f31fda65708b1a
--- /dev/null
+++ b/mash/wm/public/interfaces/shelf_layout.mojom
@@ -0,0 +1,24 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module mash.wm.mojom;
+
+enum ShelfAlignment {
+ SHELF_ALIGNMENT_BOTTOM,
+ SHELF_ALIGNMENT_LEFT,
+ SHELF_ALIGNMENT_RIGHT,
+ // TODO(msw): Why even bother including? SHELF_ALIGNMENT_TOP,
James Cook 2016/03/29 00:28:30 Don't bother, ALIGNMENT_TOP has never been support
msw 2016/04/11 22:20:27 Done.
+};
+
+enum ShelfAutoHideBehavior {
+ SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS,
+ SHELF_AUTO_HIDE_BEHAVIOR_NEVER,
+ SHELF_AUTO_HIDE_ALWAYS_HIDDEN,
+};
+
+// Used to push desired shelf state to the shelf container's layout manager.
James Cook 2016/03/29 00:28:29 nit: Is this really "desired"? It seems like sysui
msw 2016/04/11 22:20:27 I took both suggested comment changes even though
+interface ShelfLayout {
+ SetAlignment(ShelfAlignment alignment);
+ SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide);
+};
« no previous file with comments | « mash/wm/public/interfaces/BUILD.gn ('k') | mash/wm/root_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698