Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: mash/wm/public/interfaces/shelf_layout.mojom

Issue 1835403002: Support additional mash shelf alignments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mash/wm/public/interfaces/BUILD.gn ('k') | mash/wm/root_window_controller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module mash.wm.mojom;
6
7 enum ShelfAlignment {
8 SHELF_ALIGNMENT_BOTTOM,
9 SHELF_ALIGNMENT_LEFT,
10 SHELF_ALIGNMENT_RIGHT,
11 // TODO(msw): Why even bother including? SHELF_ALIGNMENT_TOP,
James Cook 2016/03/29 00:28:30 Don't bother, ALIGNMENT_TOP has never been support
msw 2016/04/11 22:20:27 Done.
12 };
13
14 enum ShelfAutoHideBehavior {
15 SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS,
16 SHELF_AUTO_HIDE_BEHAVIOR_NEVER,
17 SHELF_AUTO_HIDE_ALWAYS_HIDDEN,
18 };
19
20 // Used to push desired shelf state to the shelf container's layout manager.
James Cook 2016/03/29 00:28:29 nit: Is this really "desired"? It seems like sysui
msw 2016/04/11 22:20:27 I took both suggested comment changes even though
21 interface ShelfLayout {
22 SetAlignment(ShelfAlignment alignment);
23 SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide);
24 };
OLDNEW
« no previous file with comments | « mash/wm/public/interfaces/BUILD.gn ('k') | mash/wm/root_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698