Index: chrome/browser/banners/app_banner_debug_log.h |
diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h |
index ca742690118d15b3023d38ee135f43f6e8ef5db6..dea5e5ca58bd67f59c73f4b6d4ca9785fb8885c6 100644 |
--- a/chrome/browser/banners/app_banner_debug_log.h |
+++ b/chrome/browser/banners/app_banner_debug_log.h |
@@ -6,6 +6,7 @@ |
#define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ |
#include <string> |
+#include "content/public/browser/render_frame_host.h" |
dgozman
2016/03/25 22:30:21
Not used.
pfeldman
2016/03/25 23:42:09
Done.
|
namespace content { |
class WebContents; |
@@ -14,34 +15,38 @@ class WebContents; |
namespace banners { |
// Error message strings used to notify developers via the console. |
-extern const char kRendererRequestCancel[]; |
-extern const char kManifestEmpty[]; |
-extern const char kNoManifest[]; |
-extern const char kNoIconMatchingRequirements[]; |
-extern const char kCannotDownloadIcon[]; |
-extern const char kNoMatchingServiceWorker[]; |
-extern const char kNoIconAvailable[]; |
-extern const char kUserNavigatedBeforeBannerShown[]; |
-extern const char kStartURLNotValid[]; |
-extern const char kManifestMissingNameOrShortName[]; |
-extern const char kManifestMissingSuitableIcon[]; |
-extern const char kNotLoadedInMainFrame[]; |
-extern const char kNotServedFromSecureOrigin[]; |
-extern const char kIgnoredNotSupportedOnAndroid[]; |
-extern const char kIgnoredNoId[]; |
-extern const char kIgnoredIdsDoNotMatch[]; |
+ |
+enum OutputDeveloperMessageCode { |
dgozman
2016/03/25 22:30:21
enum class?
pfeldman
2016/03/25 23:42:09
Ack.
|
+ kRendererRequestCancel, |
+ kManifestEmpty, |
+ kNoManifest, |
+ kNoIconMatchingRequirements, |
+ kCannotDownloadIcon, |
+ kNoMatchingServiceWorker, |
+ kNoIconAvailable, |
+ kUserNavigatedBeforeBannerShown, |
+ kStartURLNotValid, |
+ kManifestMissingNameOrShortName, |
+ kManifestMissingSuitableIcon, |
+ kNotLoadedInMainFrame, |
+ kNotServedFromSecureOrigin, |
+ kIgnoredNotSupportedOnAndroid, |
+ kIgnoredNoId, |
+ kIgnoredIdsDoNotMatch, |
+}; |
// Logs a message to the main console if a banner could not be shown |
// and the engagement checks have been bypassed. |
void OutputDeveloperNotShownMessage(content::WebContents* web_contents, |
- const std::string& message, |
+ OutputDeveloperMessageCode code, |
bool is_debug_mode); |
-// Logs a debugging message to the main console if the engagement checks have |
-// been bypassed. |
-void OutputDeveloperDebugMessage(content::WebContents* web_contents, |
- const std::string& message, |
- bool is_debug_mode); |
+// Logs a message to the main console if a banner could not be shown |
+// and the engagement checks have been bypassed. |
+void OutputDeveloperNotShownMessage(content::WebContents* web_contents, |
+ OutputDeveloperMessageCode code, |
+ const std::string& param, |
+ bool is_debug_mode); |
} // namespace banners |