DevTools: make app banner debug messages report with different severity

chrome/browser/banners/app_banner_debug_log.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
 
 #include <string>
+#include "content/public/browser/render_frame_host.h"

[dgozman, 2016/03/25 22:30:21]

Not used.

[pfeldman, 2016/03/25 23:42:09]

Done.

 
 namespace content {
 class WebContents;
 }  // namespace content
 
 namespace banners {
 
 // Error message strings used to notify developers via the console.
-extern const char kRendererRequestCancel[];
-extern const char kManifestEmpty[];
-extern const char kNoManifest[];
-extern const char kNoIconMatchingRequirements[];
-extern const char kCannotDownloadIcon[];
-extern const char kNoMatchingServiceWorker[];
-extern const char kNoIconAvailable[];
-extern const char kUserNavigatedBeforeBannerShown[];
-extern const char kStartURLNotValid[];
-extern const char kManifestMissingNameOrShortName[];
-extern const char kManifestMissingSuitableIcon[];
-extern const char kNotLoadedInMainFrame[];
-extern const char kNotServedFromSecureOrigin[];
-extern const char kIgnoredNotSupportedOnAndroid[];
-extern const char kIgnoredNoId[];
-extern const char kIgnoredIdsDoNotMatch[];
+
+enum OutputDeveloperMessageCode {

[dgozman, 2016/03/25 22:30:21]

enum class?

[pfeldman, 2016/03/25 23:42:09]

Ack.

+  kRendererRequestCancel,
+  kManifestEmpty,
+  kNoManifest,
+  kNoIconMatchingRequirements,
+  kCannotDownloadIcon,
+  kNoMatchingServiceWorker,
+  kNoIconAvailable,
+  kUserNavigatedBeforeBannerShown,
+  kStartURLNotValid,
+  kManifestMissingNameOrShortName,
+  kManifestMissingSuitableIcon,
+  kNotLoadedInMainFrame,
+  kNotServedFromSecureOrigin,
+  kIgnoredNotSupportedOnAndroid,
+  kIgnoredNoId,
+  kIgnoredIdsDoNotMatch,
+};
 
 // Logs a message to the main console if a banner could not be shown
 // and the engagement checks have been bypassed.
 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
-                                    const std::string& message,
+                                    OutputDeveloperMessageCode code,
                                     bool is_debug_mode);
 
-// Logs a debugging message to the main console if the engagement checks have
-// been bypassed.
-void OutputDeveloperDebugMessage(content::WebContents* web_contents,
-                                 const std::string& message,
-                                 bool is_debug_mode);
+// Logs a message to the main console if a banner could not be shown
+// and the engagement checks have been bypassed.
+void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
+                                    OutputDeveloperMessageCode code,
+                                    const std::string& param,
+                                    bool is_debug_mode);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_