Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1835063002: DevTools: make app banner debug messages report with different severity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: show manifest content Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
6 #define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
7 7
8 #include <string> 8 #include <string>
9 #include "content/public/browser/render_frame_host.h"
dgozman 2016/03/25 22:30:21 Not used.
pfeldman 2016/03/25 23:42:09 Done.
9 10
10 namespace content { 11 namespace content {
11 class WebContents; 12 class WebContents;
12 } // namespace content 13 } // namespace content
13 14
14 namespace banners { 15 namespace banners {
15 16
16 // Error message strings used to notify developers via the console. 17 // Error message strings used to notify developers via the console.
17 extern const char kRendererRequestCancel[]; 18
18 extern const char kManifestEmpty[]; 19 enum OutputDeveloperMessageCode {
dgozman 2016/03/25 22:30:21 enum class?
pfeldman 2016/03/25 23:42:09 Ack.
19 extern const char kNoManifest[]; 20 kRendererRequestCancel,
20 extern const char kNoIconMatchingRequirements[]; 21 kManifestEmpty,
21 extern const char kCannotDownloadIcon[]; 22 kNoManifest,
22 extern const char kNoMatchingServiceWorker[]; 23 kNoIconMatchingRequirements,
23 extern const char kNoIconAvailable[]; 24 kCannotDownloadIcon,
24 extern const char kUserNavigatedBeforeBannerShown[]; 25 kNoMatchingServiceWorker,
25 extern const char kStartURLNotValid[]; 26 kNoIconAvailable,
26 extern const char kManifestMissingNameOrShortName[]; 27 kUserNavigatedBeforeBannerShown,
27 extern const char kManifestMissingSuitableIcon[]; 28 kStartURLNotValid,
28 extern const char kNotLoadedInMainFrame[]; 29 kManifestMissingNameOrShortName,
29 extern const char kNotServedFromSecureOrigin[]; 30 kManifestMissingSuitableIcon,
30 extern const char kIgnoredNotSupportedOnAndroid[]; 31 kNotLoadedInMainFrame,
31 extern const char kIgnoredNoId[]; 32 kNotServedFromSecureOrigin,
32 extern const char kIgnoredIdsDoNotMatch[]; 33 kIgnoredNotSupportedOnAndroid,
34 kIgnoredNoId,
35 kIgnoredIdsDoNotMatch,
36 };
33 37
34 // Logs a message to the main console if a banner could not be shown 38 // Logs a message to the main console if a banner could not be shown
35 // and the engagement checks have been bypassed. 39 // and the engagement checks have been bypassed.
36 void OutputDeveloperNotShownMessage(content::WebContents* web_contents, 40 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
37 const std::string& message, 41 OutputDeveloperMessageCode code,
38 bool is_debug_mode); 42 bool is_debug_mode);
39 43
40 // Logs a debugging message to the main console if the engagement checks have 44 // Logs a message to the main console if a banner could not be shown
41 // been bypassed. 45 // and the engagement checks have been bypassed.
42 void OutputDeveloperDebugMessage(content::WebContents* web_contents, 46 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
43 const std::string& message, 47 OutputDeveloperMessageCode code,
44 bool is_debug_mode); 48 const std::string& param,
49 bool is_debug_mode);
45 50
46 } // namespace banners 51 } // namespace banners
47 52
48 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 53 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
OLDNEW
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698