Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1834933003: Fix tautologous DCHECK in base::internal::JSONParser. (Closed)

Created:
4 years, 9 months ago by Robert Sesek
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tautologous DCHECK in base::internal::JSONParser. BUG=596278 R=mark@chromium.org Committed: https://crrev.com/19c6150642d7ab6a5a455b36b85efd6715028425 Cr-Commit-Position: refs/heads/master@{#383316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/json/json_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 9 months ago (2016-03-25 17:13:20 UTC) #2
Mark Mentovai
LGTM
4 years, 9 months ago (2016-03-25 18:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834933003/1
4 years, 9 months ago (2016-03-25 18:20:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 18:26:19 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:27:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/19c6150642d7ab6a5a455b36b85efd6715028425
Cr-Commit-Position: refs/heads/master@{#383316}

Powered by Google App Engine
This is Rietveld 408576698