base/json/json_parser.cc - Issue 1834933003: Fix tautologous DCHECK in base::internal::JSONParser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_parser.cc

Issue 1834933003: Fix tautologous DCHECK in base::internal::JSONParser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_parser.cc

diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc

index fbd4da45fb1405b71da3d5e4bd8387480038187c..d270471074f0fd35f5eba3a8474ff2b912bc6e0f 100644

--- a/base/json/json_parser.cc

+++ b/base/json/json_parser.cc

@@ -309,7 +309,7 @@ JSONParser::StringBuilder::~StringBuilder() {

void JSONParser::StringBuilder::Append(const char& c) {

DCHECK_GE(c, 0);

- DCHECK_LT(c, 128);

+ DCHECK_LT(static_cast<unsigned char>(c), 128);

if (string_)

string_->push_back(c);

« no previous file with comments | « no previous file | no next file » | no next file with comments »