cc : Fix layer transform changed tracking bug

cc : Fix layer transform changed tracking bug

One of the functions makes changes on a local copy of property trees
instead of the property trees stored on LayerTreeImpl. This fixes that.

BUG=597143
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/516062893e27d20dcec188a67af3a0e0c28dc902
Cr-Commit-Position: refs/heads/master@{#383219}

[jaydasika, 2016-03-24 23:46:41]

Description was changed from

==========
cc : Fix layer transform changed tracking bug

One of the functions makes changes on a local copy of property trees
instead of the property trees stored on LayerTreeImpl. This fixes that.

BUG=597143
==========

to

==========
cc : Fix layer transform changed tracking bug

One of the functions makes changes on a local copy of property trees
instead of the property trees stored on LayerTreeImpl. This fixes that.

BUG=597143
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-24 23:48:02]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org

[ajuma, 2016-03-24 23:55:53]

https://codereview.chromium.org/1834883002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1834883002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest.cc:740:
layer_tree_host()->property_trees()->needs_rebuild = true;
This is accessing the LayerTreeHost from the compositor thread. This should
happen in DidCommit() instead (using source_frame_number to pick the right
frame).

[jaydasika, 2016-03-25 00:05:25]

https://codereview.chromium.org/1834883002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1834883002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest.cc:740:
layer_tree_host()->property_trees()->needs_rebuild = true;
On 2016/03/24 23:55:53, ajuma wrote:
> This is accessing the LayerTreeHost from the compositor thread. This should
> happen in DidCommit() instead (using source_frame_number to pick the right
> frame).

Done.

[ajuma, 2016-03-25 00:06:51]

Thanks, lgtm

[jaydasika, 2016-03-25 00:34:51]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-03-25 00:35:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834883002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834883002/2

[commit-bot: I haz the power, 2016-03-25 01:44:45]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2016-03-25 01:45:42]

Description was changed from

==========
cc : Fix layer transform changed tracking bug

One of the functions makes changes on a local copy of property trees
instead of the property trees stored on LayerTreeImpl. This fixes that.

BUG=597143
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Fix layer transform changed tracking bug

One of the functions makes changes on a local copy of property trees
instead of the property trees stored on LayerTreeImpl. This fixes that.

BUG=597143
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/516062893e27d20dcec188a67af3a0e0c28dc902
Cr-Commit-Position: refs/heads/master@{#383219}
==========

[commit-bot: I haz the power, 2016-03-25 01:45:43]

Patchset 2 (id:??) landed as
https://crrev.com/516062893e27d20dcec188a67af3a0e0c28dc902
Cr-Commit-Position: refs/heads/master@{#383219}

[chrishtr, 2016-03-25 02:19:06]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-03-25 02:19:07]

Is this bad enough to warrant merging into M50 beta?

[jaydasika, 2016-03-25 02:20:37]

On 2016/03/25 02:19:07, chrishtr wrote:
> Is this bad enough to warrant merging into M50 beta?

The original CL landed after M50 branch point.