cc : Fix layer transform changed tracking bug

cc/trees/layer_tree_host_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 674 matching lines @@
   int index_;
 };
 
 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestPushPropertiesTo);
 
 // Verify damage status of property trees is preserved after commit.
 class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {
  protected:
   void SetupTree() override {
     scoped_refptr<Layer> root = Layer::Create();
+    scoped_refptr<Layer> child = Layer::Create();
+    // This is to force the child to create a transform and effect node.
+    child->SetForceRenderSurface(true);
+    root->AddChild(std::move(child));
     layer_tree_host()->SetRootLayer(root);
     LayerTreeHostTest::SetupTree();
   }
 
   enum Animations {
     OPACITY,
     TRANSFORM,
     FILTER,
     END,
   };
@@ skipping 13 matching lines @@
             PropertyTrees::ResetFlags::ALL_TREES);
         impl->active_tree()->root_layer()->OnOpacityAnimated(0.5f);
         PostSetNeedsCommitToMainThread();
         break;
       case TRANSFORM:
         index_++;
         EXPECT_TRUE(impl->active_tree()->root_layer()->LayerPropertyChanged());
         impl->active_tree()->ResetAllChangeTracking(
             PropertyTrees::ResetFlags::EFFECT_TREE);
         EXPECT_FALSE(impl->active_tree()->root_layer()->LayerPropertyChanged());
+        EXPECT_FALSE(impl->active_tree()
+                         ->root_layer()
+                         ->child_at(0)
+                         ->LayerPropertyChanged());
         transform.Translate(10, 10);
         impl->active_tree()->root_layer()->OnTransformAnimated(transform);
+        // We rebuild property trees on main thread to test the code path of
+        // damage status synchronization when property trees are different.
+        layer_tree_host()->property_trees()->needs_rebuild = true;

[ajuma, 2016/03/24 23:55:53]

This is accessing the LayerTreeHost from the compositor thread. This should
happen in DidCommit() instead (using source_frame_number to pick the right
frame).

[jaydasika, 2016/03/25 00:05:25]

Done.

         PostSetNeedsCommitToMainThread();
         break;
       case FILTER:
         index_++;
         EXPECT_TRUE(impl->active_tree()->root_layer()->LayerPropertyChanged());
+        EXPECT_TRUE(impl->active_tree()
+                        ->root_layer()
+                        ->child_at(0)
+                        ->LayerPropertyChanged());
         impl->active_tree()->ResetAllChangeTracking(
             PropertyTrees::ResetFlags::TRANSFORM_TREE);
         EXPECT_FALSE(impl->active_tree()->root_layer()->LayerPropertyChanged());
+        EXPECT_FALSE(impl->active_tree()
+                         ->root_layer()
+                         ->child_at(0)
+                         ->LayerPropertyChanged());
         filters.Append(FilterOperation::CreateOpacityFilter(0.5f));
         impl->active_tree()->root_layer()->OnFilterAnimated(filters);
         PostSetNeedsCommitToMainThread();
         break;
       case END:
         EXPECT_TRUE(impl->active_tree()->root_layer()->LayerPropertyChanged());
         EndTest();
         break;
     }
   }
@@ skipping 5903 matching lines @@
     EndTest();
   }
 
   void AfterTest() override {}
 };
 
 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestPaintedDeviceScaleFactor);
 
 }  // namespace
 }  // namespace cc