Issue 1834743003: Precompilation: don't start the service isolate in product mode. Remove vm service tree shaking roo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1834743003: Precompilation: don't start the service isolate in product mode. Remove vm service tree shaking roo… (Closed)

Created:
4 years, 9 months ago by rmacnak

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Precompilation: don't start the service isolate in product mode. Remove vm service tree shaking roots from product mode. precompiled dart2js arm 20331349 -> 19685177 (-3.17%) R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8606e22993df8de3466fc2d1d8de360f09b51692

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -19 lines)			Patch
	M	runtime/bin/main.cc	View	1	4 chunks	+21 lines, -19 lines	0 comments	Download
	M	runtime/vm/precompiler.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 9 months ago (2016-03-24 21:35:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8606e22993df8de3466fc2d1d8de360f09b51692 (presubmit successful).