Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: runtime/vm/precompiler.cc

Issue 1834743003: Precompilation: don't start the service isolate in product mode. Remove vm service tree shaking roo… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index d3578394ca9d7fa76529533a59e9722f666a24d5..dcabc029a72ad1d0e0c4799db3aa99caa06c398f 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -282,6 +282,14 @@ void Precompiler::AddRoots(Dart_QualifiedFunctionName embedder_entry_points[]) {
}
Dart_QualifiedFunctionName vm_entry_points[] = {
+ // TODO(rmacnak): These types are not allocated from C++ but they are
+ // cached in the object store. Consider clearing them from the object store
+ // before snapshotting and adjusting InitKnownObjects to allow their
+ // absence.
+ { "dart:async", "Future", "Future." },
+ { "dart:async", "Completer", "Completer." },
+ { "dart:async", "StreamIterator", "StreamIterator." },
+
// Functions
{ "dart:async", "::", "_setScheduleImmediateClosure" },
{ "dart:core", "::", "_completeDeferredLoads" },
@@ -314,9 +322,11 @@ void Precompiler::AddRoots(Dart_QualifiedFunctionName embedder_entry_points[]) {
{ "dart:typed_data", "ByteData", "ByteData." },
{ "dart:typed_data", "ByteData", "ByteData._view" },
{ "dart:typed_data", "ByteBuffer", "ByteBuffer._New" },
+#if !defined(PRODUCT)
{ "dart:_vmservice", "::", "_registerIsolate" },
{ "dart:_vmservice", "::", "boot" },
{ "dart:developer", "Metrics", "_printMetrics" },
+#endif // !PRODUCT
// Fields
{ "dart:core", "Error", "_stackTrace" },
{ "dart:math", "_Random", "_state" },
« no previous file with comments | « runtime/bin/main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698