[debugger] allow debug-evaluate to change stack and context values.

[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206, chromium:569811
LOG=N

Committed: https://crrev.com/297daf6c37d6e4145e8aaec12ccc9762ac180850
Cr-Commit-Position: refs/heads/master@{#35145}

[Yang, 2016-03-24 14:03:55]

Benedikt, please take a look at src/ast.
Ulan, please take a look at src/heap.
Camillo, please look at the rest.

Short explaination:
Instead of copying the context chain, we just use the original one. To be able
to resolve stack-allocated variables however, we materialize them and wrap the
original context and the materialized object into a debug-evaluate context.

Debug-evaluate contexts cause dynamic lookup similar to with contexts.
Context::Lookup has special handling for debug-evaluate contexts.

Debug-evaluate contexts can also contain a whitelist to make sure we can only
resolve variable names we are sure to get right (names that the current function
already uses).

[Yang, 2016-03-24 14:05:26]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 14:05:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/1

[Yang, 2016-03-24 14:06:06]

Description was changed from

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:214206
LOG=N
==========

to

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206
LOG=N
==========

[Yang, 2016-03-24 14:20:11]

Description was changed from

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206
LOG=N
==========

to

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206,chromium:569811
LOG=N
==========

[commit-bot: I haz the power, 2016-03-24 14:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 14:22:22]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15838)

[Yang, 2016-03-29 09:47:10]

On 2016/03/24 14:22:22, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15838)

Uploaded new patchset. Please take a look.

[Yang, 2016-03-29 09:53:26]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 09:53:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/20001

[Benedikt Meurer, 2016-03-29 09:55:06]

LGTM on ast.

[ulan, 2016-03-29 10:25:31]

heap lgtm

[commit-bot: I haz the power, 2016-03-29 10:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 10:38:22]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Yang, 2016-03-29 11:11:54]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 11:11:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/40001

[commit-bot: I haz the power, 2016-03-29 11:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 11:24:30]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17631)

[Yang, 2016-03-29 11:53:25]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 11:53:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/60001

[commit-bot: I haz the power, 2016-03-29 12:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 12:11:41]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15917)

[Yang, 2016-03-29 12:26:39]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 12:26:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/80001

[commit-bot: I haz the power, 2016-03-29 13:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 13:03:11]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-03-30 22:54:51]

lgtm

https://codereview.chromium.org/1834633003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/1834633003/diff/1/src/factory.cc#newcode815
src/factory.cc:815: extension.is_null() ? NULL : *extension);
nit: should probably use nullptr here

[Yang, 2016-03-31 05:33:09]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-03-31 05:33:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, ulan@chromium.org, cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1834633003/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-03-31 05:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834633003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834633003/100001

[commit-bot: I haz the power, 2016-03-31 05:58:50]

Description was changed from

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206,chromium:569811
LOG=N
==========

to

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206,chromium:569811
LOG=N
==========

[commit-bot: I haz the power, 2016-03-31 05:58:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-31 06:00:36]

Description was changed from

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206,chromium:569811
LOG=N
==========

to

==========
[debugger] allow debug-evaluate to change stack and context values.

R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org
BUG=chromium:124206,chromium:569811
LOG=N

Committed: https://crrev.com/297daf6c37d6e4145e8aaec12ccc9762ac180850
Cr-Commit-Position: refs/heads/master@{#35145}
==========

[commit-bot: I haz the power, 2016-03-31 06:00:37]

Patchset 6 (id:??) landed as
https://crrev.com/297daf6c37d6e4145e8aaec12ccc9762ac180850
Cr-Commit-Position: refs/heads/master@{#35145}