Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: src/debug/debug-evaluate.h

Issue 1834633003: [debugger] allow debug-evaluate to change stack and context values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/contexts-inl.h ('k') | src/debug/debug-evaluate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-evaluate.h
diff --git a/src/debug/debug-evaluate.h b/src/debug/debug-evaluate.h
index c0b1f027d16c2e11e0a0b56b36caf25c42d22d4d..72412312c909d2f8195645db262888a3c155408e 100644
--- a/src/debug/debug-evaluate.h
+++ b/src/debug/debug-evaluate.h
@@ -53,21 +53,17 @@ class DebugEvaluate : public AllStatic {
void UpdateValues();
- Handle<Context> innermost_context() const { return innermost_context_; }
- Handle<Context> native_context() const { return native_context_; }
+ Handle<Context> evaluation_context() const { return evaluation_context_; }
Handle<SharedFunctionInfo> outer_info() const { return outer_info_; }
private:
struct ContextChainElement {
- Handle<Context> original_context;
- Handle<Context> cloned_context;
- Handle<JSObject> materialized_object;
Handle<ScopeInfo> scope_info;
+ Handle<Context> wrapped_context;
+ Handle<JSObject> materialized_object;
+ Handle<StringSet> whitelist;
};
- void RecordContextsInChain(Handle<Context>* inner_context,
- Handle<Context> first, Handle<Context> last);
-
Handle<JSObject> NewJSObjectWithNullProto();
// Helper function to find or create the arguments object for
@@ -75,29 +71,14 @@ class DebugEvaluate : public AllStatic {
void MaterializeArgumentsObject(Handle<JSObject> target,
Handle<JSFunction> function);
- void MaterializeContextChain(Handle<JSObject> target,
- Handle<Context> context);
-
- void UpdateContextChainFromMaterializedObject(Handle<JSObject> source,
- Handle<Context> context);
-
- Handle<Context> MaterializeReceiver(Handle<Context> parent_context,
- Handle<Context> lookup_context,
- Handle<JSFunction> local_function,
- Handle<JSFunction> global_function,
- bool this_is_non_local);
-
- MaybeHandle<Object> LoadFromContext(Handle<Context> context,
- Handle<String> name, bool* global);
-
- void StoreToContext(Handle<Context> context, Handle<String> name,
- Handle<Object> value);
+ void MaterializeReceiver(Handle<JSObject> target,
+ Handle<Context> local_context,
+ Handle<JSFunction> local_function,
+ Handle<StringSet> non_locals);
Handle<SharedFunctionInfo> outer_info_;
- Handle<Context> innermost_context_;
- Handle<Context> native_context_;
+ Handle<Context> evaluation_context_;
List<ContextChainElement> context_chain_;
- List<Handle<String> > non_locals_;
Isolate* isolate_;
JavaScriptFrame* frame_;
int inlined_jsframe_index_;
« no previous file with comments | « src/contexts-inl.h ('k') | src/debug/debug-evaluate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698