Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 18346006: Update OS X to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 5 months ago by Ryan Sleevi
Modified:
7 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, ahutter, dcheng, Albert Bodenhamer, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), benquan, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, haitaol+watch_chromium.org, penghuang+watch_chromium.org, asvitkine+watch_chromium.org, Raman Kakilate, rouslan+autofillwatch_chromium.org, rsimha+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Update OS X to use scoped_refptr<T>::get() rather than implicit "operator T*" Fixes a number of cases either not caught by the automated tool or that have recently regressed. BUG=206189 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209554

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -166 lines) Patch
M cc/resources/picture_layer_tiling.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_main_app_mode_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/run_loop_testing.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cloud_print/gcp20/prototype/dns_sd_server.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 7 chunks +36 lines, -38 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_layer_mac.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/indexed_db/proxy_webidbdatabase_impl.cc View 8 chunks +48 lines, -35 lines 0 comments Download
M content/child/indexed_db/proxy_webidbfactory_impl.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 5 chunks +25 lines, -9 lines 0 comments Download
M net/cert/x509_certificate.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
TBR while burning down the edge cases on the non-Clang platforms.
7 years, 5 months ago (2013-07-01 19:55:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/18346006/1
7 years, 5 months ago (2013-07-01 19:56:02 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/browser/indexed_db/indexed_db_callbacks_wrapper.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 5 months ago (2013-07-01 23:56:28 UTC) #3
Ryan Sleevi
7 years, 5 months ago (2013-07-02 00:14:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r209554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698