chrome/browser/app_controller_mac.mm - Issue 18346006: Update OS X to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 18346006: Update OS X to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 63c42b6604dd21acc3c3785ee9ec8dcc72f209e9..f2253371c6c6aece90ea02551010152ff11aa58c 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -1328,7 +1328,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

applications.begin();

cursor != applications.end();

++cursor, ++position) {

- DCHECK_EQ(applications.GetPosition(*cursor), position);

+ DCHECK_EQ(applications.GetPosition(cursor->get()), position);

NSString* itemStr =

base::SysUTF16ToNSString(UTF8ToUTF16((*cursor)->name()));

base::scoped_nsobject<NSMenuItem> appItem(

« no previous file with comments | « chrome/app/chrome_main_app_mode_mac.mm ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »