Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1834573002: [Media Router WebUI] Handle header height changes. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Handle header height changes. Previously, there were two issues: - The header height is expanded to 62px when the email is shown, but not reduced back to 52px when the email is later hidden. - The positioning update is only done for the sink view. This change includes: - Removing the height styling from CSS and setting it explicitly in the header element. - Wrapping everything under the first run flow and header in a div for positioning updating purposes. BUG=597414, 597411 Committed: https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d Cr-Commit-Position: refs/heads/master@{#383216}

Patch Set 1 : #

Total comments: 1

Messages

Total messages: 17 (11 generated)
apacible
PTAL, thanks! FYI the html file has an addition in lines 63 and 218 with ...
4 years, 9 months ago (2016-03-24 18:59:19 UTC) #9
amp
https://codereview.chromium.org/1834573002/diff/60001/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js File chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js (right): https://codereview.chromium.org/1834573002/diff/60001/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js#newcode230 chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:230: this.headerWithoutEmailHeight_ + 'px'; Thanks for updating this. I thought ...
4 years, 9 months ago (2016-03-24 19:06:53 UTC) #10
mark a. foltz
lgtm
4 years, 9 months ago (2016-03-24 23:45:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834573002/60001
4 years, 9 months ago (2016-03-25 01:13:58 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 9 months ago (2016-03-25 01:19:23 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 01:20:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d
Cr-Commit-Position: refs/heads/master@{#383216}

Powered by Google App Engine
This is Rietveld 408576698