Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js

Issue 1834573002: [Media Router WebUI] Handle header height changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
diff --git a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
index 73b6b1982bed5eeb87c6d44ce1cb6aa5e0bf5369..c9581d2b591ca9293d1c8d4cc076e28870ab5697 100644
--- a/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
+++ b/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
@@ -46,6 +46,16 @@ Polymer({
},
/**
+ * The height of the header when it doesn't show the user email.
+ * @private {number}
+ */
+ headerWithoutEmailHeight_: {
+ type: Number,
+ readOnly: true,
+ value: 52,
+ },
+
+ /**
* Whether to show the user email in the header.
* @type {boolean}
*/
@@ -216,7 +226,8 @@ Polymer({
this.$$('#header-toolbar').style.height =
this.showEmail && !this.isEmptyOrWhitespace_(this.userEmail) ?
- this.headerWithEmailHeight_ + 'px' : undefined;
+ this.headerWithEmailHeight_ + 'px' :
+ this.headerWithoutEmailHeight_ + 'px';
amp 2016/03/24 19:06:53 Thanks for updating this. I thought I had verifie
// Only fire if height actually changed.
if (currentHeight != this.offsetHeight) {

Powered by Google App Engine
This is Rietveld 408576698