Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: components/offline_pages/BUILD.gn

Issue 1834563002: initial add of SQL based storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/BUILD.gn
diff --git a/components/offline_pages/BUILD.gn b/components/offline_pages/BUILD.gn
index 84a6601ba7e1e7fff0cc6685c358ba37896bed1c..4a03e7955ea3764ce4e159f87e51887e10488c8d 100644
--- a/components/offline_pages/BUILD.gn
+++ b/components/offline_pages/BUILD.gn
@@ -18,6 +18,8 @@ static_library("offline_pages") {
"offline_page_metadata_store.h",
"offline_page_metadata_store_impl.cc",
"offline_page_metadata_store_impl.h",
+ "offline_page_metadata_store_sql.cc",
+ "offline_page_metadata_store_sql.h",
"offline_page_model.cc",
"offline_page_model.h",
]
@@ -30,6 +32,7 @@ static_library("offline_pages") {
"//components/leveldb_proto",
"//components/offline_pages/proto:offline_pages_proto",
"//net",
+ "//sql",
"//third_party/leveldatabase",
"//url",
]
@@ -84,6 +87,7 @@ source_set("unit_tests") {
"//components/bookmarks/test",
"//components/leveldb_proto",
"//components/offline_pages/proto:offline_pages_proto",
+ "//sql:sql",
Scott Hess - ex-Googler 2016/04/25 19:57:55 Why is this //sql:sql while the other was //sql?
bburns 2016/04/26 23:27:02 good question, changed the other to sql:sql (they'
Scott Hess - ex-Googler 2016/04/27 15:21:00 In that case ... why //sql:sql but not //url:url?
bburns 2016/04/27 19:59:21 if you do "//foo" it implicitly means "//foo:foo"
Scott Hess - ex-Googler 2016/04/27 21:16:45 I'm fine with a "don't care", mostly I was pointin
"//testing/gtest",
"//url",
]

Powered by Google App Engine
This is Rietveld 408576698