Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: components/offline_pages/BUILD.gn

Issue 1834563002: initial add of SQL based storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 } 7 }
8 8
9 # GYP: //components/offline_pages.gypi:offline_pages 9 # GYP: //components/offline_pages.gypi:offline_pages
10 static_library("offline_pages") { 10 static_library("offline_pages") {
11 sources = [ 11 sources = [
12 "offline_page_archiver.h", 12 "offline_page_archiver.h",
13 "offline_page_bookmark_bridge.cc", 13 "offline_page_bookmark_bridge.cc",
14 "offline_page_bookmark_bridge.h", 14 "offline_page_bookmark_bridge.h",
15 "offline_page_item.cc", 15 "offline_page_item.cc",
16 "offline_page_item.h", 16 "offline_page_item.h",
17 "offline_page_metadata_store.cc", 17 "offline_page_metadata_store.cc",
18 "offline_page_metadata_store.h", 18 "offline_page_metadata_store.h",
19 "offline_page_metadata_store_impl.cc", 19 "offline_page_metadata_store_impl.cc",
20 "offline_page_metadata_store_impl.h", 20 "offline_page_metadata_store_impl.h",
21 "offline_page_metadata_store_sql.cc",
22 "offline_page_metadata_store_sql.h",
21 "offline_page_model.cc", 23 "offline_page_model.cc",
22 "offline_page_model.h", 24 "offline_page_model.h",
23 ] 25 ]
24 26
25 deps = [ 27 deps = [
26 ":switches", 28 ":switches",
27 "//base", 29 "//base",
28 "//components/bookmarks/browser", 30 "//components/bookmarks/browser",
29 "//components/keyed_service/core", 31 "//components/keyed_service/core",
30 "//components/leveldb_proto", 32 "//components/leveldb_proto",
31 "//components/offline_pages/proto:offline_pages_proto", 33 "//components/offline_pages/proto:offline_pages_proto",
32 "//net", 34 "//net",
35 "//sql",
33 "//third_party/leveldatabase", 36 "//third_party/leveldatabase",
34 "//url", 37 "//url",
35 ] 38 ]
36 } 39 }
37 40
38 static_library("test_support") { 41 static_library("test_support") {
39 testonly = true 42 testonly = true
40 sources = [ 43 sources = [
41 "offline_page_test_archiver.cc", 44 "offline_page_test_archiver.cc",
42 "offline_page_test_archiver.h", 45 "offline_page_test_archiver.h",
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 deps = [ 80 deps = [
78 ":offline_pages", 81 ":offline_pages",
79 ":switches", 82 ":switches",
80 ":test_support", 83 ":test_support",
81 "//base", 84 "//base",
82 "//base/test:test_support", 85 "//base/test:test_support",
83 "//components/bookmarks/browser", 86 "//components/bookmarks/browser",
84 "//components/bookmarks/test", 87 "//components/bookmarks/test",
85 "//components/leveldb_proto", 88 "//components/leveldb_proto",
86 "//components/offline_pages/proto:offline_pages_proto", 89 "//components/offline_pages/proto:offline_pages_proto",
90 "//sql:sql",
Scott Hess - ex-Googler 2016/04/25 19:57:55 Why is this //sql:sql while the other was //sql?
bburns 2016/04/26 23:27:02 good question, changed the other to sql:sql (they'
Scott Hess - ex-Googler 2016/04/27 15:21:00 In that case ... why //sql:sql but not //url:url?
bburns 2016/04/27 19:59:21 if you do "//foo" it implicitly means "//foo:foo"
Scott Hess - ex-Googler 2016/04/27 21:16:45 I'm fine with a "don't care", mostly I was pointin
87 "//testing/gtest", 91 "//testing/gtest",
88 "//url", 92 "//url",
89 ] 93 ]
90 } 94 }
91 95
92 if (is_android) { 96 if (is_android) {
93 java_cpp_enum("offline_page_feature_enums_java") { 97 java_cpp_enum("offline_page_feature_enums_java") {
94 sources = [ 98 sources = [
95 "offline_page_feature.h", 99 "offline_page_feature.h",
96 ] 100 ]
97 } 101 }
98 102
99 java_cpp_enum("offline_page_model_enums_java") { 103 java_cpp_enum("offline_page_model_enums_java") {
100 sources = [ 104 sources = [
101 "offline_page_model.h", 105 "offline_page_model.h",
102 ] 106 ]
103 } 107 }
104 } 108 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698