Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1834553002: Remove strange integral constants for "true", "false", "%PDF". (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove strange integral constants for "true", "false", "%PDF". Compilers have good inline memcmp nowadays, so we don't have to resort to old tricks. Remove FXDWORD_FROM_LSBFIRST and FXDWORD_FROM_MSBFIRST while we're at it. MSBFIRST was technically wrong due to promotion to int. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/282cee1b5ef000c8b03f53f5cbb243893d4440d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M core/fxcrt/include/fx_system.h View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-24 00:34:27 UTC) #2
dsinclair
lgtm
4 years, 9 months ago (2016-03-24 00:40:49 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-24 17:43:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
282cee1b5ef000c8b03f53f5cbb243893d4440d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698