Remove strange integral constants for "true", "false", "%PDF".

core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/pageint.h"
 
 #include <limits.h>
 
@@ skipping 227 matching lines @@
       FXSYS_memcpy(pData, m_pBuf + m_Pos, dwStreamSize);
       m_Pos += dwStreamSize;
     }
   }
   pDict->SetAtInteger("Length", (int)dwStreamSize);
   return new CPDF_Stream(pData, dwStreamSize, pDict);
 }
 
 #define MAX_WORD_BUFFER 256
 #define MAX_STRING_LENGTH 32767
-#define FXDWORD_TRUE FXDWORD_FROM_LSBFIRST(0x65757274)
-#define FXDWORD_NULL FXDWORD_FROM_LSBFIRST(0x6c6c756e)
-#define FXDWORD_FALS FXDWORD_FROM_LSBFIRST(0x736c6166)
+
 CPDF_StreamParser::SyntaxType CPDF_StreamParser::ParseNextElement() {
   if (m_pLastObj) {
     m_pLastObj->Release();
     m_pLastObj = nullptr;
   }
 
   m_WordSize = 0;
   FX_BOOL bIsNumber = TRUE;
   if (!PositionIsInBounds())
     return EndOfData;
@@ skipping 40 matching lines @@
 
     if (PDFCharIsDelimiter(ch) || PDFCharIsWhitespace(ch)) {
       m_Pos--;
       break;
     }
   }
 
   m_WordBuffer[m_WordSize] = 0;
   if (bIsNumber)
     return Number;
+
   if (m_WordBuffer[0] == '/')
     return Name;
 
   if (m_WordSize == 4) {
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_TRUE) {
+    if (memcmp(m_WordBuffer, "true", 4) == 0) {
       m_pLastObj = new CPDF_Boolean(TRUE);
       return Others;
     }
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_NULL) {
+    if (memcmp(m_WordBuffer, "null", 4) == 0) {
       m_pLastObj = new CPDF_Null;
       return Others;
     }
   } else if (m_WordSize == 5) {
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_FALS && m_WordBuffer[4] == 'e') {
+    if (memcmp(m_WordBuffer, "false", 5) == 0) {
       m_pLastObj = new CPDF_Boolean(FALSE);
       return Others;
     }
   }
   return Keyword;
 }
 
 void CPDF_StreamParser::SkipPathObject() {
   FX_DWORD command_startpos = m_Pos;
   if (!PositionIsInBounds())
@@ skipping 108 matching lines @@
         pArray->Add(pObj);
         continue;
       }
 
       if (m_WordSize == 0 || m_WordBuffer[0] == ']')
         break;
     }
     return pArray;
   }
   if (m_WordSize == 4) {
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_TRUE) {
+    if (memcmp(m_WordBuffer, "true", 4) == 0) {
       return new CPDF_Boolean(TRUE);
     }
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_NULL) {
+    if (memcmp(m_WordBuffer, "null", 4) == 0) {
       return new CPDF_Null;
     }
   } else if (m_WordSize == 5) {
-    if (*(FX_DWORD*)m_WordBuffer == FXDWORD_FALS && m_WordBuffer[4] == 'e') {
+    if (memcmp(m_WordBuffer, "false", 5) == 0) {
       return new CPDF_Boolean(FALSE);
     }
   }
   return NULL;
 }
 
 void CPDF_StreamParser::GetNextWord(FX_BOOL& bIsNumber) {
   m_WordSize = 0;
   bIsNumber = TRUE;
   if (!PositionIsInBounds())
@@ skipping 412 matching lines @@
       }
       m_Status = Done;
       return;
     }
     steps++;
     if (pPause && pPause->NeedToPauseNow()) {
       break;
     }
   }
 }