Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1834523002: [Offline pages] Making sure reload snackbar is multiline when necessary (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Making sure reload snackbar is multiline when necessary This patch makes sure it is possible to show a complete message related to the offline page reload. This means splitting the message in two lines when necessary. BUG=594986 Review URL: https://codereview.chromium.org/1820903003 Cr-Commit-Position: refs/heads/master@{#382457} (cherry picked from commit cee67051c2c03f202ffad75332f94b4f2b33a4de) Committed: https://chromium.googlesource.com/chromium/src/+/3dccd03dda7fabbab96f38366c8ffe48f97824e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
4 years, 9 months ago (2016-03-23 22:51:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dccd03dda7fabbab96f38366c8ffe48f97824e4.

Powered by Google App Engine
This is Rietveld 408576698