Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1820903003: [Offline pages] Making sure reload snackbar is multiline when necessary (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Making sure reload snackbar is multiline when necessary This patch makes sure it is possible to show a complete message related to the offline page reload. This means splitting the message in two lines when necessary. BUG=594986 Committed: https://crrev.com/cee67051c2c03f202ffad75332f94b4f2b33a4de Cr-Commit-Position: refs/heads/master@{#382457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fgorski
PTAL
4 years, 9 months ago (2016-03-21 23:37:29 UTC) #2
Pete Williamson
lgtm
4 years, 9 months ago (2016-03-21 23:38:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820903003/1
4 years, 9 months ago (2016-03-21 23:41:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 00:27:54 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 00:28:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cee67051c2c03f202ffad75332f94b4f2b33a4de
Cr-Commit-Position: refs/heads/master@{#382457}

Powered by Google App Engine
This is Rietveld 408576698