Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1834383002: Add a timeline recorder that drops new events after its buffer is full. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a timeline recorder that drops new events after its buffer is full. (With --complete-timeline, my iPod runs of memory processing the timeline. With the ring recorder, the startup events have already been bumped out by time I can connect to Observatory.) BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/1539647e4d3eb2cfc6773b1f1ce06886f6f940f4

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -35 lines) Patch
M runtime/vm/timeline.h View 1 4 chunks +41 lines, -9 lines 0 comments Download
M runtime/vm/timeline.cc View 1 12 chunks +43 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-03-28 23:46:40 UTC) #3
Cutch
Nice! LGTM
4 years, 8 months ago (2016-03-29 15:01:26 UTC) #4
rmacnak
4 years, 8 months ago (2016-03-29 18:01:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1539647e4d3eb2cfc6773b1f1ce06886f6f940f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698