Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: runtime/vm/timeline.h

Issue 1834383002: Add a timeline recorder that drops new events after its buffer is full. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index f16056e956288d8091fce2f4f8727fecfaa0c33b..0e0cf734ba3436f9f75d1bf7e5833e8366bced77 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -330,6 +330,7 @@ class TimelineEvent {
friend class TimelineEventRecorder;
friend class TimelineEventEndlessRecorder;
friend class TimelineEventRingRecorder;
+ friend class TimelineEventStartupRecorder;
friend class TimelineStream;
friend class TimelineTestHelper;
DISALLOW_COPY_AND_ASSIGN(TimelineEvent);
@@ -574,8 +575,9 @@ class TimelineEventBlock {
friend class Thread;
friend class TimelineEventRecorder;
- friend class TimelineEventRingRecorder;
friend class TimelineEventEndlessRecorder;
+ friend class TimelineEventRingRecorder;
+ friend class TimelineEventStartupRecorder;
friend class TimelineTestHelper;
friend class JSONStream;
@@ -689,26 +691,22 @@ class TimelineEventRecorder {
};
-// A recorder that stores events in a ring buffer of fixed capacity.
-class TimelineEventRingRecorder : public TimelineEventRecorder {
+// An abstract recorder that stores events in a buffer of fixed capacity.
+class TimelineEventFixedBufferRecorder : public TimelineEventRecorder {
public:
static const intptr_t kDefaultCapacity = 8192;
- explicit TimelineEventRingRecorder(intptr_t capacity = kDefaultCapacity);
- ~TimelineEventRingRecorder();
+ explicit TimelineEventFixedBufferRecorder(intptr_t capacity);
+ ~TimelineEventFixedBufferRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
- const char* name() const {
- return "ring";
- }
protected:
TimelineEvent* StartEvent();
void CompleteEvent(TimelineEvent* event);
TimelineEventBlock* GetHeadBlockLocked();
intptr_t FindOldestBlockIndex() const;
- TimelineEventBlock* GetNewBlockLocked();
void Clear();
void PrintJSONEvents(JSONArray* array, TimelineEventFilter* filter);
@@ -720,6 +718,40 @@ class TimelineEventRingRecorder : public TimelineEventRecorder {
};
+// A recorder that stores events in a buffer of fixed capacity. When the buffer
+// is full, new events overwrite old events.
+class TimelineEventRingRecorder : public TimelineEventFixedBufferRecorder {
+ public:
+ explicit TimelineEventRingRecorder(intptr_t capacity = kDefaultCapacity)
+ : TimelineEventFixedBufferRecorder(capacity) {}
+ ~TimelineEventRingRecorder() {}
+
+ const char* name() const {
+ return "ring";
+ }
+
+ protected:
+ TimelineEventBlock* GetNewBlockLocked();
+};
+
+
+// A recorder that stores events in a buffer of fixed capacity. When the buffer
+// is full, new events are dropped.
+class TimelineEventStartupRecorder : public TimelineEventFixedBufferRecorder {
+ public:
+ explicit TimelineEventStartupRecorder(intptr_t capacity = kDefaultCapacity)
+ : TimelineEventFixedBufferRecorder(capacity) {}
+ ~TimelineEventStartupRecorder() {}
+
+ const char* name() const {
+ return "startup";
+ }
+
+ protected:
+ TimelineEventBlock* GetNewBlockLocked();
+};
+
+
// An abstract recorder that calls |OnEvent| whenever an event is complete.
// This should only be used for testing.
class TimelineEventCallbackRecorder : public TimelineEventRecorder {
« no previous file with comments | « no previous file | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698