Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/elements.cc

Issue 1834373003: [heap] Add optimized RecordWrites (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: adding helper macro Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.h » ('j') | src/heap/heap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index c8436b5cd684c84b01be76507a7a1bebc79fa1bf..a01a164ac1ad1937442f6c87c4509cf5179a8914 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -1014,10 +1014,8 @@ class ElementsAccessorBase : public ElementsAccessor {
// HeapNumbers are, hence we have to write them again.
Hannes Payer (out of office) 2016/04/01 11:34:39 Update this comment.
// For Arrays with valid Smi length, we are sure to have no HeapNumber
// indices and thus we can skip this step.
- for (uint32_t i = 0; i < nof_indices; i++) {
- Object* index = combined_keys->get(i);
- combined_keys->set(i, index);
- }
+ FIXED_ARRAY_WRITE_BARRIER(isolate->heap(), *combined_keys, 0,
+ nof_indices);
}
}
« no previous file with comments | « no previous file | src/heap/heap.h » ('j') | src/heap/heap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698