src/heap/heap.h - Issue 1834373003: [heap] Add optimized RecordWrites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1834373003: [heap] Add optimized RecordWrites (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: adding helper macro Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index 3226828c2210436afae35a0440bc489d349aa705..fd769e0bf7d96bcaec11320a67997b8cbf69b11b 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -1078,6 +1078,7 @@ class Heap {

// Write barrier support for object[offset] = o;

inline void RecordWrite(Object* object, int offset, Object* o);

+ inline void RecordWrites(FixedArray* array, int offset, int length);

Hannes Payer (out of office) 2016/04/01 11:34:40 Let's call it RecordFixedArrayElements.

Address* store_buffer_top_address() {

return reinterpret_cast<Address*>(&roots_[kStoreBufferTopRootIndex]);